Skip to content

DOCSP-43327 - ExpressionTranslationOptions #233

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mongoKart
Copy link
Collaborator

@mongoKart mongoKart commented Sep 18, 2024

Pull Request Info

PR Reviewing Guidelines

JIRA - https://jira.mongodb.org/browse/DOCSP-43327

Staging Links

  • fundamentals/connection/connection-options
  • whats-new
  • Self-Review Checklist

    • Is this free of any warnings or errors in the RST?
    • Did you run a spell-check?
    • Did you run a grammar-check?
    • Are all the links working?
    • Are the facets and meta keywords accurate?

    Copy link

    netlify bot commented Sep 18, 2024

    Deploy Preview for mongodb-docs-csharp ready!

    Name Link
    🔨 Latest commit 933f903
    🔍 Latest deploy log https://app.netlify.com/sites/mongodb-docs-csharp/deploys/66eb2e17450b7300087d7a97
    😎 Deploy Preview https://deploy-preview-233--mongodb-docs-csharp.netlify.app
    📱 Preview on mobile
    Toggle QR Code...

    QR Code

    Use your smartphone camera to open QR code link.

    To edit notification comments on pull requests, go to your Netlify site configuration.

    - | Specifies options, such as the {+mdb-server+} version, for translating LINQ
    | queries to the Query API.
    |
    | **Data Type**: `ExpressionTranslationOptions <{+new-api-root+}/MongoDB.Driver/MongoDB.Driver.ExpressionTranslationOptions.html>`__
    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    This link will be broken until the APIs are published.

    Copy link
    Collaborator

    @rustagir rustagir left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    approving with a note to add some more detail to the option description. happy to take another look if needed!

    @mongoKart mongoKart requested review from rustagir, a team and papafe and removed request for a team September 19, 2024 18:17
    Copy link
    Collaborator

    @rstam rstam left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    LGTM

    @@ -49,6 +49,9 @@ The 3.0 driver release includes the following new features:
    `mongocsharpdriver <https://www.nuget.org/packages/mongocsharpdriver/#readme-body-tab>`__ NuGet package,
    which implements the v1.x driver API in driver versions 2.x. This package will no
    longer receive updates.
    - Adds the ``MongoClientSettings.TranslationOptions`` connection option, which specifies
    options for translating LINQ queries to the Query API. See :ref:`csharp-connection-options`
    Copy link
    Collaborator

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    By "Query API" do you mean MQL?

    Copy link
    Collaborator Author

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    Yes. We were asked to use "Query API" in our docs.

    @mongoKart mongoKart merged commit 71129d5 into mongodb:v3.0 Sep 25, 2024
    6 checks passed
    @mongoKart mongoKart deleted the docsp-43327-expression-translation-options branch September 25, 2024 13:17
    mongoKart added a commit to mongoKart/docs-csharp that referenced this pull request May 16, 2025
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    3 participants